chore: Change default user id and gid #1164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfrancke
force-pushed
the
feat/update-default-uid-gid
branch
from
6e517d2 to
29694c6
Compare
32 tasks
lfrancke
moved this from Development: Waiting for Review
to Development: In Progress
in Stackable Engineering
26 tasks
|
I have tested this by installing the waterlevel demo on 25.3, updated everything to current 0.0.0-dev and then updated to use custom built images with this PR included. All pods and tools came up without a problem. The FSGroup setting makes it possible that all mounts are still readable/writable. |
lfrancke
force-pushed
the
feat/update-default-uid-gid
branch
from
29694c6 to
dd85797
Compare
lfrancke
moved this from Development: In Progress
to Development: Waiting for Review
in Stackable Engineering
sbernauer
moved this from Development: Waiting for Review
to Development: Done
in Stackable Engineering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of stackabletech/issues#645
Part of stackabletech/issues#651
Note
This was already applied once before and later reverted.
It was merged prematurely back then but now the immediate parent issue has been done and it should be good to go again
Change default user id and gid to the same ones we use in the operators themselves.
These are only the defaults that are used when a Pod does not specify their own
securityContext.runAsUserorrunAsGroup.All of our operators have been changed to not set the user and group id anymore which means they'll fall back to the values from the image.
Definition of Done Checklist
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
baketo retrieve the image tag for<image-tagged-with-the-major-version>.